[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAPDyKFqGGAzgLFJOKmOpLVT8ai4ymHXUbva85U6JtEd=M9kb4Q@mail.gmail.com>
Date: Tue, 20 Aug 2024 13:49:41 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Chen Wang <unicornxw@...il.com>
Cc: adrian.hunter@...el.com, aou@...s.berkeley.edu, conor+dt@...nel.org,
guoren@...nel.org, inochiama@...look.com, jszhang@...nel.org,
krzysztof.kozlowski+dt@...aro.org, palmer@...belt.com,
paul.walmsley@...ive.com, robh@...nel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org,
linux-riscv@...ts.infradead.org, chao.wei@...hgo.com, haijiao.liu@...hgo.com,
xiaoguang.xing@...hgo.com, tingzhu.wang@...hgo.com,
Chen Wang <unicorn_wang@...look.com>
Subject: Re: [PATCH v6 0/8] mmc: sdhci-of-dwcmshc: Add Sophgo SG2042 support
On Mon, 5 Aug 2024 at 11:15, Chen Wang <unicornxw@...il.com> wrote:
>
> From: Chen Wang <unicorn_wang@...look.com>
>
> This patchset is composed of two parts:
> - one is the improvement of the sdhci-of-dwcmshc framework,
> - the other is the support for sg2042 based on the improvement of the
> framework.
> The reason for merging the two parts into one patchset is mainly to
> facilitate review, especially to facilitate viewing why we need to
> improve the framework and what benefits it will bring to us.
>
> When I tried to add a new soc(SG2042) to sdhci-of-dwcmshc, I found
> that the existing driver code could be optimized to facilitate expansion
> for the new soc. Patch 1 ~ Patch 5 is for this.
>
> Patch 6 ~ 7 are adding support for the mmc controller for Sophgo SG2042.
> Adding corresponding new compatible strings, and implement
> custom callbacks for SG2042 based on new framework.
>
> Patch 8 is the change for DTS.
>
> By the way, although I believe this patch only optimizes the framework
> of the code and does not change the specific logic, simple verification
> is certainly better. Since I don't have rk35xx/th1520 related hardware,
> it would be greatly appreciated if someone could help verify it.
>
> ---
>
> Changes in v6:
>
> The patch series is based on latest 'next' branch of [mmc-git].
>
> - Some minor improvements based on Adrian's review suggestions.
> - Added Reviewed-by and Tested-by signatures from Conor/Drew/Inochi.
>
Patch 1 -> 7 applied for next, thanks!
Kind regards
Uffe
Powered by blists - more mailing lists