linux-kernel - 答复: [PATCH v1] usb: gadget: u_serial: check Null pointer in EP callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID:
 <TYUPR06MB6217F8B2397EAFCC67240E46D28D2@TYUPR06MB6217.apcprd06.prod.outlook.com>
Date: Tue, 20 Aug 2024 12:04:47 +0000
From: 胡连勤 <hulianqin@...o.com>
To: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC: "quic_prashk@...cinc.com" <quic_prashk@...cinc.com>,
	"quic_jjohnson@...cinc.com" <quic_jjohnson@...cinc.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	opensource.kernel <opensource.kernel@...o.com>, "akpm@...ux-foundation.org"
	<akpm@...ux-foundation.org>, Michael Nazzareno Trimarchi
	<michael@...rulasolutions.com>
Subject:
 答复: [PATCH v1] usb: gadget: u_serial: check Null pointer in EP callback

Hello linux community expert:

> > >> Call trace:
> > >> gs_read_complete+0x58/0x240
> > >> usb_gadget_giveback_request+0x40/0x160
> > >> dwc3_remove_requests+0x170/0x484
> > >> dwc3_ep0_out_start+0xb0/0x1d4
> > >> __dwc3_gadget_start+0x25c/0x720
> > >> kretprobe_trampoline.cfi_jt+0x0/0x8
> > >> kretprobe_trampoline.cfi_jt+0x0/0x8
> > >> udc_bind_to_driver+0x1d8/0x300
> > >> usb_gadget_probe_driver+0xa8/0x1dc
> > >> gadget_dev_desc_UDC_store+0x13c/0x188
> > >> configfs_write_iter+0x160/0x1f4
> > >> vfs_write+0x2d0/0x40c
> > >> ksys_write+0x7c/0xf0
> > >> __arm64_sys_write+0x20/0x30
> > >> invoke_syscall+0x60/0x150
> > >> el0_svc_common+0x8c/0xf8
> > >> do_el0_svc+0x28/0xa0
> > >> el0_svc+0x24/0x84
> > >> el0t_64_sync_handler+0x88/0xec
> > >> el0t_64_sync+0x1b4/0x1b8
> > >> Code: aa1f03e1 aa1303e0 52800022 2a0103e8 (88e87e62) ---[ end trace 
> > >> 938847327a739172 ]--- Kernel panic - not syncing: Oops: Fatal 
> > >> exception
> > >> 
> > >> Signed-off-by: Lianqin Hu <hulianqin@...o.com>
> > >> ---
> > >> v1:
> > >   - Optimize code comments, delete log printing
> > 
> > >Also, same comment as before, what:
> > >  - causes port to be NULL
> >    When unbind, the gser_unbind function call gserial_disconnect to set gser->ioport = NULL, and struct gs_port *port = gser->ioport, resulting in port being NULL.
> >    It seems that there is a potential competition between the gs_read_complete function and the gserial_disconnect function.

> Then fix that properly please.
  OK, we are preparing a new patch and will submit the new version patch later.

>Any specific reason you ignored my previous review comments?
 Replying here in response to a question asked previously.

Thanks