linux-kernel - Re: [PATCH v4 2/2] dma: add IOMMU static calls with clear default ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240820122240.GA17459@lst.de>
Date: Tue, 20 Aug 2024 14:22:40 +0200
From: Christoph Hellwig <hch@....de>
To: Robin Murphy <robin.murphy@....com>
Cc: Christoph Hellwig <hch@....de>, Leon Romanovsky <leon@...nel.org>,
	Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Leon Romanovsky <leonro@...dia.com>,
	Easwar Hariharan <eahariha@...ux.microsoft.com>,
	linux-kernel@...r.kernel.org, iommu@...ts.linux.dev,
	Jason Gunthorpe <jgg@...dia.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v4 2/2] dma: add IOMMU static calls with clear default
 ops

On Mon, Aug 19, 2024 at 02:16:56PM +0100, Robin Murphy wrote:
> Thanks, I've just had a quick look over what you queued on 
> dma-iommu-direct-calls, and you're welcome to stick my ack on that if you 
> like.

Yes, thank you a lot for your review!

While I have your attention - with these two patches we stop building
dummy_dma_ops for most common configs.  Do you think we need additional
safeguards for this case?  My idea would be to remove them and force the
bus_dma_mask to zero where we currently set the dummy ops, but I could
use a little reality check for that idea.