linux-kernel - Re: [PATCH] leds: lp55xx: Use devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8ae467b-de1b-4c65-a2b0-877ef887f9ae@wanadoo.fr>
Date: Tue, 20 Aug 2024 15:13:53 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Huan Yang <link@...o.com>, Pavel Machek <pavel@....cz>,
 Lee Jones <lee@...nel.org>, linux-leds@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: opensource.kernel@...o.com
Subject: Re: [PATCH] leds: lp55xx: Use devm_clk_get_enabled() helpers

Le 20/08/2024 à 12:20, Huan Yang a écrit :
> lp55xx lp55xx_is_extclk_used get, enable clk and
> deinit_device disable and unprepare it.
> 
> This can use a simplifies helper to cover.
> 
> Signed-off-by: Huan Yang <link@...o.com>
> ---

Hi,

if you want to go 1 step further, I think that 'vlk' can now also be 
removed from struct lp55xx_chip.

Just my 2c.

CJ


>   drivers/leds/leds-lp55xx-common.c | 14 ++------------
>   1 file changed, 2 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/leds/leds-lp55xx-common.c b/drivers/leds/leds-lp55xx-common.c
> index 29e7142dca72..76dc62a3bd45 100644
> --- a/drivers/leds/leds-lp55xx-common.c
> +++ b/drivers/leds/leds-lp55xx-common.c
> @@ -965,21 +965,14 @@ EXPORT_SYMBOL_GPL(lp55xx_update_bits);
>   bool lp55xx_is_extclk_used(struct lp55xx_chip *chip)
>   {
>   	struct clk *clk;
> -	int err;
>   
> -	clk = devm_clk_get(&chip->cl->dev, "32k_clk");
> +	clk = devm_clk_get_enabled(&chip->cl->dev, "32k_clk");
>   	if (IS_ERR(clk))
>   		goto use_internal_clk;
>   
> -	err = clk_prepare_enable(clk);
> -	if (err)
> +	if (clk_get_rate(clk) != LP55XX_CLK_32K)
>   		goto use_internal_clk;
>   
> -	if (clk_get_rate(clk) != LP55XX_CLK_32K) {
> -		clk_disable_unprepare(clk);
> -		goto use_internal_clk;
> -	}
> -
>   	dev_info(&chip->cl->dev, "%dHz external clock used\n",	LP55XX_CLK_32K);
>   
>   	chip->clk = clk;
> @@ -995,9 +988,6 @@ static void lp55xx_deinit_device(struct lp55xx_chip *chip)
>   {
>   	struct lp55xx_platform_data *pdata = chip->pdata;
>   
> -	if (chip->clk)
> -		clk_disable_unprepare(chip->clk);
> -
>   	if (pdata->enable_gpiod)
>   		gpiod_set_value(pdata->enable_gpiod, 0);
>   }