lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <248b38f3-3cb6-4dd8-825b-e4d2083a99ef@lunn.ch>
Date: Tue, 20 Aug 2024 15:25:28 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Wei Fang <wei.fang@....com>
Cc: "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>,
	"hkallweit1@...il.com" <hkallweit1@...il.com>,
	"linux@...linux.org.uk" <linux@...linux.org.uk>,
	"Andrei Botila (OSS)" <andrei.botila@....nxp.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 1/3] dt-bindings: net: tja11xx: use reverse-mode
 to instead of rmii-refclk-in

> > Sorry, I didn't find the correct PHY driver, could you point me to which PHY
> > driver that I can refer to?
> > The PHY drivers I searched for using the "clk" keyword all seem to set the
> > clock via a vendor defined property. Such as,
> > realtek: "realtek,clkout-disable"
> > dp83867 and dp83869: "ti,clk-output-sel" and
> > "ti,sgmii-ref-clock-output-enable"
> > motorcomm: " motorcomm,tx-clk-1000-inverted"
> > micrel: "rmii-ref"
> 
> Hi Andrew,
> I still cannot find a generic method in other PHY drivers to provide
> reference clock by PHY. So I think this patch is the best I could do, at
> least it's more reasonable than the "nxp,rmii-refclk-in" property.

I did not say there was a generic method. I just said copy one. We
have too many different ways of doing the same thing, so we should not
add another one. Which of these is closest to what you want? You
should use your own vendor part, but copy clk-output-sel, rmii-ref,
etc, and implement the same behaviour in your driver.

     Andrew

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ