[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240820132234.2759926-7-shikemeng@huaweicloud.com>
Date: Tue, 20 Aug 2024 21:22:33 +0800
From: Kemeng Shi <shikemeng@...weicloud.com>
To: tytso@....edu,
adilger.kernel@...ger.ca
Cc: harshadshirwadkar@...il.com,
darrick.wong@...cle.com,
akpm@...l.org,
shaggy@...tin.ibm.com,
linux-ext4@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH v2 6/7] ext4: remove unneeded NULL check of buffer_head in ext4_mark_inode_used()
If gdp from ext4_get_group_desc() is not NULL, then returned group_desc_bh
won't be NULL either. Remove check of group_desc_bh and only check
returned gdp from ext4_get_group_desc() like how other callers do.
Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
---
fs/ext4/ialloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index 0234f5e91d8d..daacb9f0ef50 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -772,7 +772,7 @@ int ext4_mark_inode_used(struct super_block *sb, int ino)
}
gdp = ext4_get_group_desc(sb, group, &group_desc_bh);
- if (!gdp || !group_desc_bh) {
+ if (!gdp) {
err = -EINVAL;
goto out;
}
--
2.30.0
Powered by blists - more mailing lists