[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240820132234.2759926-8-shikemeng@huaweicloud.com>
Date: Tue, 20 Aug 2024 21:22:34 +0800
From: Kemeng Shi <shikemeng@...weicloud.com>
To: tytso@....edu,
adilger.kernel@...ger.ca
Cc: harshadshirwadkar@...il.com,
darrick.wong@...cle.com,
akpm@...l.org,
shaggy@...tin.ibm.com,
linux-ext4@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH v2 7/7] ext4: check buffer_verified in advance to avoid unneeded ext4_get_group_info()
Check buffer_verified in advance to avoid unneeded ext4_get_group_info().
This could be a simple cleanup as compiler may handle this.
Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
---
fs/ext4/ialloc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index daacb9f0ef50..7f1a5f90dbbd 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -87,10 +87,10 @@ static int ext4_validate_inode_bitmap(struct super_block *sb,
if (EXT4_SB(sb)->s_mount_state & EXT4_FC_REPLAY)
return 0;
- grp = ext4_get_group_info(sb, block_group);
-
if (buffer_verified(bh))
return 0;
+
+ grp = ext4_get_group_info(sb, block_group);
if (!grp || EXT4_MB_GRP_IBITMAP_CORRUPT(grp))
return -EFSCORRUPTED;
--
2.30.0
Powered by blists - more mailing lists