linux-kernel - Re: [PATCH] drivers/perf: Fix ali_drw_pmu driver interrupt status clearing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a70eaa3-f1c5-4803-948b-4b8eb86190c6@linux.alibaba.com>
Date: Wed, 21 Aug 2024 10:20:55 +0800
From: Jing Zhang <renyu.zj@...ux.alibaba.com>
To: Mark Rutland <mark.rutland@....com>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 Will Deacon <will@...nel.org>, Shuai Xue <xueshuai@...ux.alibaba.com>
Subject: Re: [PATCH] drivers/perf: Fix ali_drw_pmu driver interrupt status
 clearing



在 2024/8/20 下午5:18, Mark Rutland 写道:
> On Mon, Aug 19, 2024 at 07:48:30PM +0800, Jing Zhang wrote:
>> The alibaba_uncore_pmu driver forgot to clear all interrupt status
>> in the interrupt processing function. After the PMU counter overflow
>> interrupt occurred, an interrupt storm occurred, causing the system
>> to hang.
>>
>> Therefore, clear the correct interrupt status in the interrupt handling
>> function to fix it.
>>
>> Signed-off-by: Jing Zhang <renyu.zj@...ux.alibaba.com>
> 
> Presumably this should have
> 
> Fixes: cf7b61073e4526ca ("drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710 SoC")
> 
> ... right?

You are right, I forgot it.

> 
> With that:
> 
> Acked-by: Mark Rutland <mark.rutland@....com>
> 
> Mark.
> 
>> ---
>>  drivers/perf/alibaba_uncore_drw_pmu.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c
>> index 38a2947..c6ff1bc 100644
>> --- a/drivers/perf/alibaba_uncore_drw_pmu.c
>> +++ b/drivers/perf/alibaba_uncore_drw_pmu.c
>> @@ -400,7 +400,7 @@ static irqreturn_t ali_drw_pmu_isr(int irq_num, void *data)
>>  			}
>>  
>>  			/* clear common counter intr status */
>> -			clr_status = FIELD_PREP(ALI_DRW_PMCOM_CNT_OV_INTR_MASK, 1);
>> +			clr_status = FIELD_PREP(ALI_DRW_PMCOM_CNT_OV_INTR_MASK, status);
>>  			writel(clr_status,
>>  			       drw_pmu->cfg_base + ALI_DRW_PMU_OV_INTR_CLR);
>>  		}
>> -- 
>> 1.8.3.1
>>