linux-kernel - Re: [PATCH v2] mailbox: sprd: Use devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABb+yY3drhueGsmBt_JF+ev0rw0J1xkb0xZ5jS3qynOYra_wVw@mail.gmail.com>
Date: Wed, 21 Aug 2024 09:45:53 -0500
From: Jassi Brar <jassisinghbrar@...il.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Huan Yang <link@...o.com>, Orson Zhai <orsonzhai@...il.com>, 
	Baolin Wang <baolin.wang@...ux.alibaba.com>, Chunyan Zhang <zhang.lyra@...il.com>, 
	linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v2] mailbox: sprd: Use devm_clk_get_enabled() helpers

On Wed, Aug 21, 2024 at 5:09 AM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> Le 21/08/2024 à 09:08, Huan Yang a écrit :
> >
> > 在 2024/8/21 15:00, Christophe JAILLET 写道:
> >> Le 21/08/2024 à 03:39, Huan Yang a écrit :
> >>> The devm_clk_get_enabled() helpers:
> >>>       - call devm_clk_get()
> >>>       - call clk_prepare_enable() and register what is needed in
> >>> order to
> >>>        call clk_disable_unprepare() when needed, as a managed resource.
> >>>
> >>> This simplifies the code and avoids the calls to
> >>> clk_disable_unprepare().
> >>>
> >>> Due to clk only used in probe, not in suspend\resume, this pointer can
> >>> remove from sprd_mbox_priv to save a little memory.
> >>>
> >>> Signed-off-by: Huan Yang <link@...o.com>
> >>> Suggested-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> >>
> >>
> >> Nitpick: no need to add this S-b. I just made a comment when looking
> >> at your patch in order to improve it. I'm not the one that suggested
> >> the initial change. All merit is yours.
> > Your suggestion is helpfull, help this patch be better.
> >>
> >> Also, I think that, if used, it should be above your Signed-off.
> > Hmmm, it's neccessary? If so, I'd like to update it.
>
> I don't think it is useful and personally I would remove it, but you can
> keep it if it makes sense to you.
>
I think   Reviewed-by  is appropriate.

cheers!