linux-kernel - Re: [PATCH v1 03/12] dt-bindings: nvmem: microchip-otpc: Add compatible for SAM9X60

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240821-undertake-recovery-bc05779e60e2@spud>
Date: Wed, 21 Aug 2024 15:55:59 +0100
From: Conor Dooley <conor@...nel.org>
To: Alexander Dahl <ada@...rsis.com>
Cc: Claudiu Beznea <claudiu.beznea@...on.dev>,
	Christian Melki <christian.melki@...ata.com>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	"moderated list:MICROCHIP OTPC DRIVER" <linux-arm-kernel@...ts.infradead.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 03/12] dt-bindings: nvmem: microchip-otpc: Add
 compatible for SAM9X60

On Wed, Aug 21, 2024 at 12:59:34PM +0200, Alexander Dahl wrote:
> The SAM9X60 SoC family has a similar OTPC to the SAMA7G5 family.
> 
> Signed-off-by: Alexander Dahl <ada@...rsis.com>
> ---
>  .../devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml        | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml b/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml
> index cc25f2927682..d98b6711bdfd 100644
> --- a/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml
> @@ -21,6 +21,7 @@ allOf:
>  properties:
>    compatible:
>      items:
> +      - const: microchip,sam9x60-otpc
>        - const: microchip,sama7g5-otpc
>        - const: syscon

As Rob's bot pointed out, this breaks the existing devicetrees. If you
want a fallback to the sama7g5, then you will need to add a new items
list here, alongside the existing one.

Cheers,
Conor.

>  
> -- 
> 2.39.2
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)