linux-kernel - Re: [PATCH v1 2/2] dt-bindings: EDAC for loongson memory controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240821-evasion-octane-891e772673f9@spud>
Date: Wed, 21 Aug 2024 15:59:32 +0100
From: Conor Dooley <conor@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Zhao Qunqin <zhaoqunqin@...ngson.cn>, chenhuacai@...nel.org,
	kernel@...0n.name, bp@...en8.de, tony.luck@...el.com,
	james.morse@....com, mchehab@...nel.org, rric@...nel.org,
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org,
	linux-edac@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v1 2/2] dt-bindings: EDAC for loongson memory controller

On Wed, Aug 21, 2024 at 10:20:29AM +0200, Krzysztof Kozlowski wrote:
> On 21/08/2024 08:47, Zhao Qunqin wrote:
> > From: zhaoqunqin <zhaoqunqin@...ngson.cn>
> > 
> > Add: drivers/edac/loongson_edac.c

This is not what your patch does.

> > 
> > Signed-off-by: zhaoqunqin <zhaoqunqin@...ngson.cn>
> 
> Please use full name, not login.
> 
> > ---
> >  .../bindings/edac/loongson,ls-mc-edac.yaml    | 35 +++++++++++++++++++
> 
> Bindings are before users.
> 
> >  MAINTAINERS                                   |  7 ++++
> >  2 files changed, 42 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml b/Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml
> > new file mode 100644
> > index 000000000..29e5b8381
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml
> > @@ -0,0 +1,35 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/edac/loongson,ls-mc-edac.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Loongson Memory Controller EDAC
> > +
> > +maintainers:
> > +  - Zhao Qunqin <zhaoqunqin@...ngson.cn>
> > +
> > +description: |
> > +  EDAC node is defined to describe on-chip error detection and correction for
> > +  Loongson Memory Controller.
> > +
> > +properties:
> > +
> > +  compatible:
> > +    const: loongson,ls-mc-edac
> 
> Missing soc part. And then adjust filename to match proper (new) compatible.

Please, please speak with your colleagues at Loongson that have submitted
other binding patches. Each time someone new submits one, we are back to
square one in terms of compatible strings.

Thanks,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)