linux-kernel - Re: [PATCH v1] mm: Defines obj_cgroup_get() if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZsYDoQ7NybCcXADx@tiehlicka>
Date: Wed, 21 Aug 2024 17:11:29 +0200
From: Michal Hocko <mhocko@...e.com>
To: Kanchana P Sridhar <kanchana.p.sridhar@...el.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, hannes@...xchg.org,
	yosryahmed@...gle.com, nphamcs@...il.com, ryan.roberts@....com,
	ying.huang@...el.com, 21cnbao@...il.com, akpm@...ux-foundation.org,
	nanhai.zou@...el.com, wajdi.k.feghali@...el.com,
	vinodh.gopal@...el.com
Subject: Re: [PATCH v1] mm: Defines obj_cgroup_get() if CONFIG_MEMCG is not
 defined.

On Tue 20-08-24 12:50:05, Kanchana P Sridhar wrote:
> This resolves an issue with obj_cgroup_get() not being defined
> if CONFIG_MEMCG is not defined. 

Could you paste the compilation error and which tree this is based on?

> This causes build errors if
> obj_cgroup_get() is called from code that is agnostic of CONFIG_MEMCG.
> 
> The patch resolves this.
> 
> Signed-off-by: Kanchana P Sridhar <kanchana.p.sridhar@...el.com>
> ---
>  include/linux/memcontrol.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index fe05fdb92779..f693d254ab2a 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -1281,6 +1281,10 @@ struct mem_cgroup *mem_cgroup_from_css(struct cgroup_subsys_state *css)
>  	return NULL;
>  }
>  
> +static inline void obj_cgroup_get(struct obj_cgroup *objcg)
> +{
> +}
> +
>  static inline void obj_cgroup_put(struct obj_cgroup *objcg)
>  {
>  }
> 
> base-commit: 7d0b0d4b77b368b2111fc8b4449e33dfb3c34087
> -- 
> 2.27.0
> 

-- 
Michal Hocko
SUSE Labs