linux-kernel - Re: [PATCH] virtio_pmem: Check device status before requesting flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+cxXh=7Vp0LO0jJSwKuX-8W4jAR87N8qagASb=_uqt1=7WN3Q@mail.gmail.com>
Date: Tue, 20 Aug 2024 19:46:38 -0700
From: Philip Chen <philipchen@...omium.org>
To: Ira Weiny <ira.weiny@...el.com>
Cc: Pankaj Gupta <pankaj.gupta.linux@...il.com>, Dan Williams <dan.j.williams@...el.com>, 
	Vishal Verma <vishal.l.verma@...el.com>, Dave Jiang <dave.jiang@...el.com>, 
	virtualization@...ts.linux.dev, nvdimm@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virtio_pmem: Check device status before requesting flush

Hi,

On Tue, Aug 20, 2024 at 7:23 AM Ira Weiny <ira.weiny@...el.com> wrote:
>
> Philip Chen wrote:
> > On Mon, Aug 19, 2024 at 2:56 PM Ira Weiny <ira.weiny@...el.com> wrote:
> > >
> > > Philip Chen wrote:
> > > > If a pmem device is in a bad status, the driver side could wait for
> > > > host ack forever in virtio_pmem_flush(), causing the system to hang.
> > >
> > > I assume this was supposed to be v2 and you resent this as a proper v2
> > > with a change list from v1?
> > Ah...yes, I'll fix it and re-send it as a v2 patch.
>
> Wait didn't you already do that?  Wasn't this v2?

Yes, but somehow the patch didn't go to my inbox.
(Maybe it's because there is no code change between v1 and v2?)
So I resent another v2 (with some minor change to the comment):
https://lore.kernel.org/all/20240820172256.903251-1-philipchen@chromium.org/
Please take a look.

>
> https://lore.kernel.org/all/20240815010337.2334245-1-philipchen@chromium.org/
>
> Ira