linux-kernel - Re: [PATCH v2] nfs: fix bitmap decoder to handle a 3rd word

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <358BF534-D6F3-4C05-9490-BC5B1C7B963A@redhat.com>
Date: Wed, 21 Aug 2024 11:44:35 -0400
From: Benjamin Coddington <bcodding@...hat.com>
To: Jeff Layton <jlayton@...nel.org>
Cc: Trond Myklebust <trondmy@...nel.org>, Anna Schumaker <anna@...nel.org>,
 Lance Shelton <lance.shelton@...merspace.com>, linux-nfs@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] nfs: fix bitmap decoder to handle a 3rd word

On 21 Aug 2024, at 8:28, Jeff Layton wrote:

> It only decodes the first two words at this point. Have it decode the
> third word as well. Without this, the client doesn't send delegated
> timestamps in the CB_GETATTR response.
>
> With this change we also need to expand the on-stack bitmap in
> decode_recallany_args to 3 elements, in case the server sends a larger
> bitmap than expected.
>
> Fixes: 43df7110f4a9 ("NFSv4: Add CB_GETATTR support for delegated attributes")
> Signed-off-by: Jeff Layton <jlayton@...nel.org>

Reviewed-by: Benjamin Coddington <bcodding@...hat.com>

Ben