linux-kernel - Re: [PATCH]The patch fixes the following warning generated by running the

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd5aaf11-60c3-4621-8278-16bddc1080e7@stanley.mountain>
Date: Wed, 21 Aug 2024 19:56:55 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Sayyad Abid <sayyad.abid16@...il.com>
Cc: philipp.g.hortmann@...il.com, gregkh@...uxfoundation.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH]The patch fixes the following warning generated by
 running the

On Wed, Aug 21, 2024 at 09:45:39PM +0530, Sayyad Abid wrote:
> From: abid-sayyad <sayyad.abid16@...il.com>
> 

Your email from header is better than this From header.

> diff --git a/drivers/staging/vt6656/Kconfig b/drivers/staging/vt6656/Kconfig
> index f52a3f1d9a2e..a37dc3c921ea 100644
> --- a/drivers/staging/vt6656/Kconfig
> +++ b/drivers/staging/vt6656/Kconfig
> @@ -4,4 +4,10 @@ config VT6656
>  	depends on MAC80211 && USB && WLAN && m
>  	select FW_LOADER
>  	help
> -	  This is a vendor-written driver for VIA VT6656.
> +	  This is a vendor-written driver for VIA VT6656. VIA Technology VT6656
> +	  is a wireless network controller that operates on the 2.4GHz band.
> +
> +	  If you have this hardware and wish to use it, set 'Y' or 'M' here to
> +	  compile the driver either directly in the kernel or as a module
> +	  respectively. If you are unsure, it is safe to set it to 'M'.
> +	  If enabled it loads the firmware for the mentioned device.

I feel like this second paragraph doesn't add any value.  Just ignore checkpatch
when it tells you to do stuff like this.

regards,
dan carpenter