linux-kernel - Re: [PATCH] ASoC: cs-amp-lib: Ignore empty UEFI calibration entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9361e81c-eceb-4c78-ba76-925449ac7215@sirena.org.uk>
Date: Wed, 21 Aug 2024 18:10:15 +0100
From: Mark Brown <broonie@...nel.org>
To: Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
	patches@...nsource.cirrus.com
Subject: Re: [PATCH] ASoC: cs-amp-lib: Ignore empty UEFI calibration entries

On Wed, Aug 21, 2024 at 11:02:21AM +0100, Richard Fitzgerald wrote:
> If the timestamp of a calibration entry is 0 it is an unused entry and
> must be ignored.
> 
> Some end-products reserve EFI space for calibration entries by shipping
> with a zero-filled EFI file. When searching the file for calibration
> data the driver must skip the empty entries. The timestamp of a valid
> entry is always non-zero.

This breaks the build if I apply it on either for-6.11 or for-6.12:

In file included from /build/stage/linux/sound/soc/codecs/cs-amp-lib-test.c:8:
/build/stage/linux/sound/soc/codecs/cs-amp-lib-test.c: In function ‘cs_amp_lib_test_get_efi_cal_by_uid_test’:
/build/stage/linux/sound/soc/codecs/cs-amp-lib-test.c:224:50: error: subscripted value is neither array nor pointer nor vector
  224 |         KUNIT_EXPECT_EQ(test, result_data.calTime[0],
      |                                                  ^
/build/stage/linux/include/kunit/test.h:724:22: note: in definition of macro ‘KUNIT_BASE_BINARY_ASSERTION’
  724 |         const typeof(left) __left = (left);                                    \
      |                      ^~~~

(with lots more errors) - I'm guessins some missing dependency
somewhere?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)