linux-kernel - Re: [PATCH v3 7/7] selftests/mm: add more mseal traversal tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKbZUD2ZzxRzLjeXwix=i-tdfbEC6Lrv6d0VRirJvSm8PxLmJA@mail.gmail.com>
Date: Wed, 21 Aug 2024 18:36:33 +0100
From: Pedro Falcato <pedro.falcato@...il.com>
To: Jeff Xu <jeffxu@...omium.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, "Liam R. Howlett" <Liam.Howlett@...cle.com>, 
	Vlastimil Babka <vbabka@...e.cz>, Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, 
	Shuah Khan <shuah@...nel.org>, linux-mm@...ck.org, linux-kernel@...r.kernel.org, 
	linux-kselftest@...r.kernel.org, oliver.sang@...el.com, 
	torvalds@...ux-foundation.org, Michael Ellerman <mpe@...erman.id.au>, 
	Kees Cook <kees@...nel.org>
Subject: Re: [PATCH v3 7/7] selftests/mm: add more mseal traversal tests

On Wed, Aug 21, 2024 at 6:28 PM Pedro Falcato <pedro.falcato@...il.com> wrote:
> > ok.  Then this test should be as below ? (need to add PROT_NONE page
> > before and after)
> >   size = get_vma_size(ptr, &prot);
> >   FAIL_TEST_IF_FALSE(size == 2 * page_size);
> >   FAIL_TEST_IF_FALSE(prot==0x4)
>
> That doesn't work because this region spans two vmas. I'll write
> something similar for the fixup.

Actually, I won't because this might cause spurious test failures on
e.g !TOPDOWN mmap architectures.
setup_single_address (and co) need a fresh coat of paint (wrt
PROT_NONE guard regions around it) and I don't want to be the one to
do it, at least not as part of this series.

-- 
Pedro