linux-kernel - Re: [PATCH] x86/platform/geode: switch GPIO buttons and LEDs to software properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZsYu0SEy8ZUKEJqP@google.com>
Date: Wed, 21 Aug 2024 11:15:45 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Hans de Goede <hdegoede@...hat.com>
Cc: Mark Gross <mgross@...ux.intel.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Borislav Petkov <bp@...en8.de>, linux-geode@...ts.infradead.org,
	platform-driver-x86@...r.kernel.org, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/platform/geode: switch GPIO buttons and LEDs to
 software properties

On Wed, Aug 21, 2024 at 12:15:51PM +0200, Hans de Goede wrote:
> Hi Dmitry,
> 
> On 8/21/24 7:25 AM, Dmitry Torokhov wrote:
> > Convert GPIO-connected buttons and LEDs in Geode boards to software
> > nodes/properties, so that support for platform data can be removed from
> > gpio-keys driver (which will rely purely on generic device properties
> > for configuration).
> > 
> > To avoid repeating the same data structures over and over and over
> > factor them out into a new geode-common.c file.
> > 
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> 
> Thanks, patch looks good to me:
> 
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>
> 
> Question has this been tested on at least 1 affected device ?

No unfortunately it has not been as I do not have the hardware. I am
hoping folks on geode list could give this patch a spin.

Thanks.

-- 
Dmitry