linux-kernel - Re: [PATCH v5 4/4] drm: panel-backlight-quirks: Add Framework 13 glossy and 2.8k panels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <209ec1ca-c050-4f76-bfbd-e9ec52caa1e0@amd.com>
Date: Wed, 21 Aug 2024 15:55:55 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: Thomas Weißschuh <linux@...ssschuh.net>,
 Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 Harry Wentland <harry.wentland@....com>, Leo Li <sunpeng.li@....com>,
 Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
 Matt Hartley <matt.hartley@...il.com>, Kieran Levin <ktl@...mework.net>,
 Hans de Goede <hdegoede@...hat.com>,
 Jani Nikula <jani.nikula@...ux.intel.com>, Xinhui Pan <Xinhui.Pan@....com>,
 Jonathan Corbet <corbet@....net>
Cc: amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, Dustin Howett <dustin@...ett.net>,
 linux-doc@...r.kernel.org
Subject: Re: [PATCH v5 4/4] drm: panel-backlight-quirks: Add Framework 13
 glossy and 2.8k panels

On 8/18/2024 01:56, Thomas Weißschuh wrote:
> From: "Dustin L. Howett" <dustin@...ett.net>
> 
> I have tested these panels on the Framework Laptop 13 AMD with firmware
> revision 3.05 (latest at time of submission).
> 
> Signed-off-by: Dustin L. Howett <dustin@...ett.net>

When you send someone else's patch you need to add your own S-o-b as 
well.  Please add that for v6.  Otherwise:

Reviewed-by: Mario Limonciello <mario.limonciello@....com>

> ---
>   drivers/gpu/drm/drm_panel_backlight_quirks.c | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_backlight_quirks.c b/drivers/gpu/drm/drm_panel_backlight_quirks.c
> index f2aefff618dd..c477d98ade2b 100644
> --- a/drivers/gpu/drm/drm_panel_backlight_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_backlight_quirks.c
> @@ -25,6 +25,22 @@ static const struct drm_panel_min_backlight_quirk drm_panel_min_backlight_quirks
>   		.ident.name = "NE135FBM-N41",
>   		.min_brightness = 0,
>   	},
> +	/* 13 inch glossy panel */
> +	{
> +		.dmi_match.field = DMI_BOARD_VENDOR,
> +		.dmi_match.value = "Framework",
> +		.ident.panel_id = drm_edid_encode_panel_id('B', 'O', 'E', 0x095f),
> +		.ident.name = "NE135FBM-N41",
> +		.min_brightness = 0,
> +	},
> +	/* 13 inch 2.8k panel */
> +	{
> +		.dmi_match.field = DMI_BOARD_VENDOR,
> +		.dmi_match.value = "Framework",
> +		.ident.panel_id = drm_edid_encode_panel_id('B', 'O', 'E', 0x0cb4),
> +		.ident.name = "NE135A1M-NY1",
> +		.min_brightness = 0,
> +	},
>   };
>   
>   static bool drm_panel_min_backlight_quirk_matches(const struct drm_panel_min_backlight_quirk *quirk,
>