linux-kernel - Re: [tip: x86/urgent] x86/ioremap: Use is_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6013396.DvuYhMxLoT@max8rr8pad>
Date: Thu, 22 Aug 2024 00:21:49 +0300
From: Max Ramanouski <max8rr8@...il.com>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: tip-bot2 for Max Ramanouski <tip-bot2@...utronix.de>,
 linux-tip-commits@...r.kernel.org, Christoph Hellwig <hch@....de>,
 Alistair Popple <apopple@...dia.com>, x86@...nel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [tip: x86/urgent] x86/ioremap: Use is_ioremap_addr() in iounmap()

> Please do not top-post and trim your replies.

Sorry, got a bit distracted and forgot to remove the default gmail
reply text. Will try to be more careful in future with better email
client.

> Careful, this might end up with other issues vs. the kernel header
> inclusion hell.
> If i386 is the only one which does not have VMALLOC start in
> asm/pgtable.h, then curing this might be the easier fix, no?

I thought about that initially, but then found out that apparently
it is like that for a reason. In commit:

186525bd6b8 ("mm, x86/mm: Untangle address space layout definitions from basic pgtable type definitions")

VMALLOC_START definition was specifically moved out of pgtable
related headers. But for some reason only for 32 bit arch. Plus
I think asm/vmalloc.h is more semantically correct to get
VMALLOC_START. Although on most arches (everywhere except x86,
arm64, powerpc and riscv) asm/vmalloc.h is an empty header. And
on riscv it doesn't actually provide VMALLOC_START... Probably
that is worth a separate fix later.

Best regards,
Max