linux-kernel - Re: [PATCH net-next v27 07/13] rtase: Implement a function to receive packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240821152126.519f44ea@kernel.org>
Date: Wed, 21 Aug 2024 15:21:26 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Larry Chiu <larry.chiu@...ltek.com>
Cc: Justin Lai <justinlai0215@...ltek.com>, "davem@...emloft.net"
 <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
 "pabeni@...hat.com" <pabeni@...hat.com>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, "andrew@...n.ch" <andrew@...n.ch>,
 "jiri@...nulli.us" <jiri@...nulli.us>, "horms@...nel.org"
 <horms@...nel.org>, "rkannoth@...vell.com" <rkannoth@...vell.com>,
 "jdamato@...tly.com" <jdamato@...tly.com>, Ping-Ke Shih
 <pkshih@...ltek.com>
Subject: Re: [PATCH net-next v27 07/13] rtase: Implement a function to
 receive packets

On Wed, 21 Aug 2024 09:02:41 +0000 Larry Chiu wrote:
> If all buffers are empty, it indicates that the memory allocation failed
> multiple times. Should we keep trying to allocate or just log an error 
> message and stop it?

Yes, you can keep trying to refill every time the NAPI loop exits.
That will be at most once per packet (assuming NAPI loop collected
just a single packet). I thought you wanted to return "busy" from
NAPI until memory appears. That'd be "busy polling for memory"..