linux-kernel - Re: [PATCH] padata: Honor the caller's alignment in case of chunk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240821154136.a09fa0e80903aa9ae17d43bd@linux-foundation.org>
Date: Wed, 21 Aug 2024 15:41:36 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Kamlesh Gurudasani <kamlesh@...com>
Cc: Steffen Klassert <steffen.klassert@...unet.com>, Daniel Jordan
 <daniel.m.jordan@...cle.com>, Waiman Long <longman@...hat.com>, Herbert Xu
 <herbert@...dor.apana.org.au>, <linux-crypto@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] padata: Honor the caller's alignment in case of
 chunk_size 0

On Thu, 22 Aug 2024 02:32:52 +0530 Kamlesh Gurudasani <kamlesh@...com> wrote:

> In the case where we are forcing the ps.chunk_size to be at least 1,
> we are ignoring the caller's alignment.
> 
> Move the forcing of ps.chunk_size to be at least 1 before rounding it
> up to caller's alignment, so that caller's alignment is honored.
> 
> While at it, use max() to force the ps.chunk_size to be at least 1 to
> improve readability.

Please (as always) describe the userspace-visible runtime effects of
this change.  This helps others to determine which kernel(s) should be
patched.  And it helps others decide whether this fix might address an
issue which they are encountering.