linux-kernel - Re: [PATCH 9/9] sched: Add pick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZsZyq-_vUpruRHsR@slm.duckdns.org>
Date: Wed, 21 Aug 2024 13:05:15 -1000
From: Tejun Heo <tj@...nel.org>
To: Peter Zijlstra <peterz@...radead.org>
Cc: mingo@...nel.org, void@...ifault.com, juri.lelli@...hat.com,
	vincent.guittot@...aro.org, dietmar.eggemann@....com,
	rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
	vschneid@...hat.com, linux-kernel@...r.kernel.org,
	joelaf@...gle.com
Subject: Re: [PATCH 9/9] sched: Add pick_task(.core)

Hello, Peter.

On Wed, Aug 14, 2024 at 12:25:57AM +0200, Peter Zijlstra wrote:
> In order to distinguish between a regular vs a core pick_task()
> invocation, add a boolean argument.
> 
> Notably SCX seems to need this, since its core pick

Tried converting scx to use the new interface and it looks like SCX doesn't
need this either. With small behavior changes around ENQ_LAST and
stopping/running, pick_task() can behave the same for regular and core-sched
cases.

Everything else looks fine too. Once this patchset gets applied, I'll pull
and update right away.

Thanks.

-- 
tejun