linux-kernel - Re: [PATCH] workqueue: fix null-ptr-deref on __alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240821000722.GG12106@google.com>
Date: Wed, 21 Aug 2024 09:07:22 +0900
From: Sergey Senozhatsky <senozhatsky@...omium.org>
To: Matthew Brost <matthew.brost@...el.com>
Cc: Sergey Senozhatsky <senozhatsky@...omium.org>,
	Tejun Heo <tj@...nel.org>, Lai Jiangshan <jiangshanlai@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] workqueue: fix null-ptr-deref on __alloc_workqueue()
 error

On (24/08/20 23:56), Matthew Brost wrote:
> On Wed, Aug 21, 2024 at 08:54:12AM +0900, Sergey Senozhatsky wrote:
> > On (24/08/19 11:15), Tejun Heo wrote:
> > > Hello,
> > > 
> > > On Fri, Aug 16, 2024 at 02:45:20AM +0000, Matthew Brost wrote:
> > > > > Tejun, how do you plan to handle this?  Would it be possible to
> > > > > drop current series from your tree so that Matthew can send an
> > > > > updated version (with all the fixes squashed)?
> > > > 
> > > > Tejun, yes let me know how to move forward with this as it is highly
> > > > desired for Intel Xe team to get this into 6.12.
> > > 
> > > Can you just send a fixup patch?
> > 
> > Well, this will make the tree unbisectable (for a range of versions),
> > because the errors in question break the boot.
> 
> Can the patches not just get squashed together in the 6.12 PR?

squash would be my personal preference.  Usually resend works in cases
like this (so that Link: in commit messages point to the relevant
thread), but I don't know what Tejun's planning to do.