linux-kernel - Re: [PATCH v1 1/2] Loongarch: EDAC driver for loongson memory controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85d64a341fa0d2dd57ed1078b694effc90b2e33e.camel@xry111.site>
Date: Wed, 21 Aug 2024 14:51:45 +0800
From: Xi Ruoyao <xry111@...111.site>
To: Zhao Qunqin <zhaoqunqin@...ngson.cn>, chenhuacai@...nel.org, 
	kernel@...0n.name, bp@...en8.de, tony.luck@...el.com, james.morse@....com, 
	mchehab@...nel.org, rric@...nel.org, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org
Cc: loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	linux-edac@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v1 1/2] Loongarch: EDAC driver for loongson memory
 controller

On Wed, 2024-08-21 at 14:47 +0800, Zhao Qunqin wrote:
> --- a/arch/loongarch/Kconfig
> +++ b/arch/loongarch/Kconfig
> @@ -179,6 +179,8 @@ config LOONGARCH
>  	select PCI_QUIRKS
>  	select PERF_USE_VMALLOC
>  	select RTC_LIB
> +	select EDAC_SUPPORT
> +	select EDAC

This line looks incorrect.  It's forcing the users to enable EDAC even
if they don't need it (for example using a non-ECC memory).

And no other arch does this.

-- 
Xi Ruoyao <xry111@...111.site>
School of Aerospace Science and Technology, Xidian University