[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20240821072444.8838-1-11162571@vivo.com>
Date: Wed, 21 Aug 2024 03:24:43 -0400
From: Yang Ruibin <11162571@...o.com>
To: Kashyap Desai <kashyap.desai@...adcom.com>,
Sumit Saxena <sumit.saxena@...adcom.com>,
Shivasharan S <shivasharan.srikanteshwara@...adcom.com>,
Chandrakanth patil <chandrakanth.patil@...adcom.com>,
"James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
megaraidlinux.pdl@...adcom.com,
linux-scsi@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: opensource.kernel@...o.com,
Yang Ruibin <11162571@...o.com>
Subject: [PATCH v1] drivers:megaraid:Fix the NULL vs IS_ERR() bug for debugfs_create_dir()
The debugfs_create_dir() function returns error pointers.
It never returns NULL. So use IS_ERR() to check it.
Signed-off-by: Yang Ruibin <11162571@...o.com>
---
drivers/scsi/megaraid/megaraid_sas_debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_debugfs.c b/drivers/scsi/megaraid/megaraid_sas_debugfs.c
index c69760775efa..b8b66d590571 100644
--- a/drivers/scsi/megaraid/megaraid_sas_debugfs.c
+++ b/drivers/scsi/megaraid/megaraid_sas_debugfs.c
@@ -102,7 +102,7 @@ static const struct file_operations megasas_debugfs_raidmap_fops = {
void megasas_init_debugfs(void)
{
megasas_debugfs_root = debugfs_create_dir("megaraid_sas", NULL);
- if (!megasas_debugfs_root)
+ if (IS_ERR(megasas_debugfs_root))
pr_info("Cannot create debugfs root\n");
}
@@ -132,7 +132,7 @@ megasas_setup_debugfs(struct megasas_instance *instance)
if (!instance->debugfs_root) {
instance->debugfs_root =
debugfs_create_dir(name, megasas_debugfs_root);
- if (!instance->debugfs_root) {
+ if (IS_ERR(instance->debugfs_root)) {
dev_err(&instance->pdev->dev,
"Cannot create per adapter debugfs directory\n");
return;
--
2.34.1
Powered by blists - more mailing lists