[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240821073916.10165-1-11162571@vivo.com>
Date: Wed, 21 Aug 2024 03:39:14 -0400
From: Yang Ruibin <11162571@...o.com>
To: Sebastian Reichel <sre@...nel.org>,
Stephen Rothwell <sfr@...b.auug.org.au>,
Yang Ruibin <11162571@...o.com>,
linux-kernel@...r.kernel.org
Cc: opensource.kernel@...o.com
Subject: [PATCH v1] drivers:controllers:Fix the NULL vs IS_ERR() bug for debugfs_create_dir()
The debugfs_create_dir() function returns error pointers.
It never returns NULL. So use IS_ERR() to check it.
Signed-off-by: Yang Ruibin <11162571@...o.com>
---
drivers/hsi/controllers/omap_ssi_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controllers/omap_ssi_core.c
index 3140990a6164..f85d56e85c0f 100644
--- a/drivers/hsi/controllers/omap_ssi_core.c
+++ b/drivers/hsi/controllers/omap_ssi_core.c
@@ -116,14 +116,14 @@ static int ssi_debug_add_ctrl(struct hsi_controller *ssi)
/* SSI controller */
omap_ssi->dir = debugfs_create_dir(dev_name(&ssi->device), NULL);
- if (!omap_ssi->dir)
+ if (IS_ERR(omap_ssi->dir))
return -ENOMEM;
debugfs_create_file("regs", S_IRUGO, omap_ssi->dir, ssi,
&ssi_regs_fops);
/* SSI GDD (DMA) */
dir = debugfs_create_dir("gdd", omap_ssi->dir);
- if (!dir)
+ if (IS_ERR(dir))
goto rback;
debugfs_create_file("regs", S_IRUGO, dir, ssi, &ssi_gdd_regs_fops);
--
2.34.1
Powered by blists - more mailing lists