linux-kernel - Re: [PATCH v6 4/4] clk: samsung: add top clock support for ExynosAuto v920 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a729db0-f587-42b6-8003-789091986324@kernel.org>
Date: Wed, 21 Aug 2024 10:02:27 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "sunyeal.hong" <sunyeal.hong@...sung.com>,
 'Kwanghoon Son' <k.son@...sung.com>,
 'Sylwester Nawrocki' <s.nawrocki@...sung.com>,
 'Chanwoo Choi' <cw00.choi@...sung.com>,
 'Alim Akhtar' <alim.akhtar@...sung.com>,
 'Michael Turquette' <mturquette@...libre.com>,
 'Stephen Boyd' <sboyd@...nel.org>, 'Rob Herring' <robh@...nel.org>,
 'Conor Dooley' <conor+dt@...nel.org>
Cc: linux-samsung-soc@...r.kernel.org, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 4/4] clk: samsung: add top clock support for ExynosAuto
 v920 SoC

On 21/08/2024 09:06, sunyeal.hong wrote:
>>>>>>> +	.clk_name		= "dout_clkcmu_peric0_noc",
>>>>>>
>>>>>> same question.
>>>>>> Isn't it "noc"?
>>>>>> https://lore.kernel.org/linux-samsung-
>>>>>> soc/58dfae564a4a624e464c7803a309f1f07b5ae83d.camel@...sung.com/
>>>>>>
>>>>>> In my case(autov9), if put wrong clk_name dmesg will show that,
>>>>>> exynos_arm64_register_cmu: could not enable bus clock ...; err = -2
>>>>>>
>>>>>> Kwang.
>>>>>>
>>>>>>
>>>>>
>>>>> clk_name follows the guide document provided by hw. v9 is bus, but
>>>>> v920
>>>> uses noc.
>>>>
>>>> What I mean,
>>>>
>>>> .clk_name		= "dout_clkcmu_peric0_noc", // wrong
>>>> .clk_name		= "noc", // correct
>>>>
>>>> Because there is no clock-names "dout_clkcmu_peric0_noc" in
>>>> exynos/exynosautov920.dtsi.
>>>>
>>>
>>> The clk_name written here has nothing to do with the device tree. Please
>> look at the code carefully.
>>
>> Hm? I see in the code clearly:
>>
>> 	clk_get(dev, cmu->clk_name);
>>
>> Where cmu is the discussed struct.
>>
>> If you claim it does not have anything to do with DT, then what is it for?
>>
>> Best regards,
>> Krzysztof
> 
> In general, clk_get is used via the clk_name declared in the DT.
> 
> However, the question asked here is the parent clock name of peric0_noc, so it is unrelated to the device tree.

No. The question was about clk_name entry in cmu info used directly for
clk_get.


Best regards,
Krzysztof