[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <415a27c7-dfdf-4cc5-9aaa-1681dd32ddcb@kernel.org>
Date: Wed, 21 Aug 2024 11:29:42 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Rohit Agarwal <rohiagar@...omium.org>, chunkuang.hu@...nel.org,
p.zabel@...gutronix.de, airlied@...il.com, daniel@...ll.ch,
maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com,
ck.hu@...iatek.com, jitao.shi@...iatek.com
Cc: dri-devel@...ts.freedesktop.org, linux-mediatek@...ts.infradead.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 1/3] dt-bindings: display: mediatek: dpi: Add power
domains
On 21/08/2024 11:26, Rohit Agarwal wrote:
> Add power domain binding to the mediatek DPI controller
> for MT8186.
> Also, add power domain binding for other SoCs like
> MT6795 and MT8173 that already had power domain property.
>
> Signed-off-by: Rohit Agarwal <rohiagar@...omium.org>
> ---
> .../display/mediatek/mediatek,dpi.yaml | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> index 5ca7679d5427..864b781fdcea 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> @@ -62,6 +62,8 @@ properties:
> - const: default
> - const: sleep
>
> + power-domains: true
Missing maxItems. I don't get why did you change this...
> +
> port:
> $ref: /schemas/graph.yaml#/properties/port
> description:
> @@ -76,6 +78,23 @@ required:
> - clock-names
> - port
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - mediatek,mt6795-dpi
> + - mediatek,mt8173-dpi
> + - mediatek,mt8186-dpi
> + then:
> + properties:
> + power-domains:
> + maxItems: 1
This part can be dropped. Just disallow it for other devices.
Best regards,
Krzysztof
Powered by blists - more mailing lists