linux-kernel - Re: [PATCH] usb: cdnsp: fix incorrect index in cdnsp_get_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240821102326.GA652432@nchen-desktop>
Date: Wed, 21 Aug 2024 18:23:26 +0800
From: Peter Chen <peter.chen@...nel.org>
To: Pawel Laszczak <pawell@...ence.com>
Cc: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH] usb: cdnsp: fix incorrect index in cdnsp_get_hw_deq
 function

On 24-08-20 08:21:19, Pawel Laszczak wrote:
> Patch fixes the incorrect "stream_id" table index instead of
> "ep_index" used in cdnsp_get_hw_deq function.
> 
> Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver")
> cc: <stable@...r.kernel.org>
> Signed-off-by: Pawel Laszczak <pawell@...ence.com>
> ---
>  drivers/usb/cdns3/cdnsp-ring.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/cdns3/cdnsp-ring.c b/drivers/usb/cdns3/cdnsp-ring.c
> index 75724e60653c..e0e97a138666 100644
> --- a/drivers/usb/cdns3/cdnsp-ring.c
> +++ b/drivers/usb/cdns3/cdnsp-ring.c
> @@ -402,7 +402,7 @@ static u64 cdnsp_get_hw_deq(struct cdnsp_device *pdev,
>  	struct cdnsp_stream_ctx *st_ctx;
>  	struct cdnsp_ep *pep;
>  
> -	pep = &pdev->eps[stream_id];
> +	pep = &pdev->eps[ep_index];
>  
>  	if (pep->ep_state & EP_HAS_STREAMS) {
>  		st_ctx = &pep->stream_info.stream_ctx_array[stream_id];
> -- 
> 2.43.0
> 

Reviewed-by: Peter Chen <peter.chen@...nel.org>

Peter