[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240821102727.qitmm2zxnpva4cqd@skbuf>
Date: Wed, 21 Aug 2024 13:27:27 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: Furong Xu <0x1207@...il.com>
Cc: Serge Semin <fancer.lancer@...il.com>, Andrew Lunn <andrew@...n.ch>,
"David S. Miller" <davem@...emloft.net>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Joao Pinto <jpinto@...opsys.com>, netdev@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
xfr@...look.com
Subject: Re: [PATCH net-next v4 3/7] net: stmmac: refactor FPE verification
process
On Wed, Aug 21, 2024 at 12:58:33PM +0800, Furong Xu wrote:
>
> Hi Vladimir
>
> On Tue, 20 Aug 2024 15:34:56 +0300, Vladimir Oltean <olteanv@...il.com> wrote:
> > I took the liberty of rewriting the fpe_task to a timer, and delete the
> > workqueue. Here is a completely untested patch, which at least is less
> > complex, has less code and is easier to understand. What do you think?
> >
>
> Your patch is much better than my ugly implementation ;)
Well, to be fair, it took us a number of iterations to properly see how
much it could be simplified.
> Some small fixes are required to make kselftest-ethtool_mm pass.
>
> Would you mind if I rebase you patch, fix some small issues, make sure all
> test cases pass, split it into two patches and include them in my patchset,
> then send to review as a Co-developer and a tester?
Please feel free to split up that patch and squash it into your patches,
keeping your Author: field and just a Co-developed-by: + Signed-off-by:
for me, where parts of that patch helped you.
Powered by blists - more mailing lists