[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <43c93550-941a-4a8b-9734-f7a9877ddf4d@wanadoo.fr>
Date: Wed, 21 Aug 2024 12:43:43 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Yu Jiaoliang <yujiaoliang@...o.com>, Benson Leung <bleung@...omium.org>,
Tzung-Bi Shih <tzungbi@...nel.org>, chrome-platform@...ts.linux.dev,
linux-kernel@...r.kernel.org
Cc: opensource.kernel@...o.com
Subject: Re: [PATCH v1] platform/chrome: chromeos_laptop: Use kmemdup_array
instead of kmemdup for multiple allocation
Le 21/08/2024 à 10:41, Yu Jiaoliang a écrit :
> Let the kememdup_array() take care about multiplication and possible
> overflows.
>
> Signed-off-by: Yu Jiaoliang <yujiaoliang@...o.com>
> ---
> drivers/platform/chrome/chromeos_laptop.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/chrome/chromeos_laptop.c b/drivers/platform/chrome/chromeos_laptop.c
> index a2cdbfbaeae6..7bedd82dd3a5 100644
> --- a/drivers/platform/chrome/chromeos_laptop.c
> +++ b/drivers/platform/chrome/chromeos_laptop.c
> @@ -749,10 +749,9 @@ chromeos_laptop_prepare_i2c_peripherals(struct chromeos_laptop *cros_laptop,
> if (!src->num_i2c_peripherals)
> return 0;
>
> - i2c_peripherals = kmemdup(src->i2c_peripherals,
> - src->num_i2c_peripherals *
> - sizeof(*src->i2c_peripherals),
> - GFP_KERNEL);
> + i2c_peripherals =
> + kmemdup_array(src->i2c_peripherals, src->num_i2c_peripherals,
> + sizeof(*src->i2c_peripherals), GFP_KERNEL);
> if (!i2c_peripherals)
> return -ENOMEM;
>
Nitpick: sizeof(*i2c_peripherals) would also work and is slightly less
verbose.
CJ
Powered by blists - more mailing lists