linux-kernel - Re: [PATCH net-next v5] net: netconsole: selftests: Create a new netconsole selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ikvukv3s.fsf@nvidia.com>
Date: Wed, 21 Aug 2024 12:48:08 +0200
From: Petr Machata <petrm@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Breno Leitao <leitao@...ian.org>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <pabeni@...hat.com>, <liuhangbin@...il.com>,
	<petrm@...dia.com>, <matttbe@...nel.org>, Shuah Khan <shuah@...nel.org>,
	<netdev@...r.kernel.org>, Willem de Bruijn <willemb@...gle.com>, David Wei
	<dw@...idwei.uk>, open list <linux-kernel@...r.kernel.org>, "open list:KERNEL
 SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH net-next v5] net: netconsole: selftests: Create a new
 netconsole selftest


Jakub Kicinski <kuba@...nel.org> writes:

> On Mon, 19 Aug 2024 02:03:53 -0700 Breno Leitao wrote:
>> +function check_for_dependencies() {
>> +	if [ "$(id -u)" -ne 0 ]; then
>> +		echo "This test must be run as root" >&2
>> +		exit "${ksft_skip}"
>> +	fi
>> +
>> +	if ! which socat > /dev/null ; then
>> +		echo "SKIP: socat(1) is not available" >&2
>> +		exit "${ksft_skip}"
>> +	fi
>> +
>> +	if ! which ip > /dev/null ; then
>> +		echo "SKIP: ip(1) is not available" >&2
>> +		exit "${ksft_skip}"
>> +	fi
>> +
>> +	if ! which udevadm > /dev/null ; then
>> +		echo "SKIP: udevadm(1) is not available" >&2
>> +		exit "${ksft_skip}"
>> +	fi
>> +
>> +	if [ ! -d "${NETCONS_CONFIGFS}" ]; then
>> +		echo "SKIP: directory ${NETCONS_CONFIGFS} does not exist. Check if NETCONSOLE_DYNAMIC is enabled" >&2
>> +		exit "${ksft_skip}"
>> +	fi
>> +
>> +	if ip link show "${DSTIF}" 2> /dev/null; then
>> +		echo "SKIP: interface ${DSTIF} exists in the system. Not overwriting it." >&2
>> +		exit "${ksft_skip}"
>> +	fi
>
> nit: maybe ip addr list to see if the 192.168.1.x network is already in
> use? 

Or alternatively use 192.0.2.0/24 subnet, that shouldn't be used in the
wild.