linux-kernel - Re: [PATCH v8 net-next 1/3] selftests: net: Create veth pair for testing in networkless kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240821123733.109853-1-jain.abhinav177@gmail.com>
Date: Wed, 21 Aug 2024 18:07:33 +0530
From: Abhinav Jain <jain.abhinav177@...il.com>
To: kuba@...nel.org
Cc: davem@...emloft.net,
	edumazet@...gle.com,
	jain.abhinav177@...il.com,
	javier.carrasco.cruz@...il.com,
	linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org,
	netdev@...r.kernel.org,
	pabeni@...hat.com,
	shuah@...nel.org,
	skhan@...uxfoundation.org
Subject: Re: [PATCH v8 net-next 1/3] selftests: net: Create veth pair for testing in networkless kernel

On Tue, 20 Aug 2024 16:50:06 -0700, Jakub Kicinski wrote:
> On Mon, 19 Aug 2024 17:42:33 +0530 Abhinav Jain wrote:
> > +	echo "veth0" > "$TMP_LIST_NETDEV"
> > +	echo "veth1" >> "$TMP_LIST_NETDEV"
>
> Why test both ends? 
> Aren't we going to do the same exact test twice?

I presumed that we would want to run the interface up/down, setup and ethtool tests on both veth.
If this is not required, should I submit a v9 removing veth1 from the temp list?

Also, while sending v9, do I add the Review tag from Simon or it has to be reviewed again?