lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b9504b3e-5657-5c0f-7ded-69474a9e5647@linux.intel.com>
Date: Wed, 21 Aug 2024 15:39:10 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
    Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
    Hans de Goede <hdegoede@...hat.com>, LKML <linux-kernel@...r.kernel.org>, 
    platform-driver-x86@...r.kernel.org, 
    "Rafael J. Wysocki" <rafael@...nel.org>, 
    Daniel Scally <djrscally@...il.com>
Subject: Re: [PATCH v1 2/4] platform/x86: int3472: Simplify dev_err_probe()
 usage

On Wed, 21 Aug 2024, Christophe JAILLET wrote:

> Le 21/08/2024 à 14:20, Andy Shevchenko a écrit :
> > Since dev_err_probe() ignores success,
> 
> Hi,
> 
> Does it really?
> It does not seem to be the case (at least on linux-next). Or I miss something
> obvious?

Yes, you're missing the first patch of the series. :-)

-- 
 i.


> > i.e. 0. we may call
> > it unconditionally.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > ---
> >   drivers/platform/x86/intel/int3472/discrete.c | 5 +----
> >   1 file changed, 1 insertion(+), 4 deletions(-)
> > 
> > diff --git a/drivers/platform/x86/intel/int3472/discrete.c
> > b/drivers/platform/x86/intel/int3472/discrete.c
> > index 07b302e09340..cd0743300d7f 100644
> > --- a/drivers/platform/x86/intel/int3472/discrete.c
> > +++ b/drivers/platform/x86/intel/int3472/discrete.c
> > @@ -289,10 +289,7 @@ static int skl_int3472_handle_gpio_resources(struct
> > acpi_resource *ares,
> >   	int3472->ngpios++;
> >   	ACPI_FREE(obj);
> >   -	if (ret < 0)
> > -		return dev_err_probe(int3472->dev, ret, err_msg);
> > -
> > -	return ret;
> > +	return dev_err_probe(int3472->dev, ret, err_msg);
> >   }
> >     static int skl_int3472_parse_crs(struct int3472_discrete_device
> > *int3472)
> 
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ