linux-kernel - Re: [PATCH v1 3/4] platform/x86: int3472: Use GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c99b8ee1-dec1-689c-5f0c-dc45e6b984ae@linux.intel.com>
Date: Wed, 21 Aug 2024 15:41:30 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
    Hans de Goede <hdegoede@...hat.com>, LKML <linux-kernel@...r.kernel.org>, 
    platform-driver-x86@...r.kernel.org, 
    "Rafael J. Wysocki" <rafael@...nel.org>, 
    Daniel Scally <djrscally@...il.com>
Subject: Re: [PATCH v1 3/4] platform/x86: int3472: Use GPIO_LOOKUP() macro

On Wed, 21 Aug 2024, Andy Shevchenko wrote:

> Use GPIO_LOOKUP() macro which provides a compound literal
> and can be used with dynamic data.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/platform/x86/intel/int3472/discrete.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c
> index cd0743300d7f..96a9673a0165 100644
> --- a/drivers/platform/x86/intel/int3472/discrete.c
> +++ b/drivers/platform/x86/intel/int3472/discrete.c
> @@ -69,11 +69,7 @@ static int skl_int3472_fill_gpiod_lookup(struct gpiod_lookup *table_entry,
>  	if (!adev)
>  		return -ENODEV;
>  
> -	table_entry->key = acpi_dev_name(adev);
> -	table_entry->chip_hwnum = agpio->pin_table[0];
> -	table_entry->con_id = func;
> -	table_entry->idx = 0;
> -	table_entry->flags = polarity;
> +	*table_entry = GPIO_LOOKUP(acpi_dev_name(adev), agpio->pin_table[0], func, polarity);
>  
>  	return 0;
>  }
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.