linux-kernel - Re: [PATCH] mtd: nand: raw: atmel: Add message on DMA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240821-ouch-tanned-fed30ba26700@thorsis.com>
Date: Wed, 21 Aug 2024 15:20:19 +0200
From: Alexander Dahl <ada@...rsis.com>
To: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: Alexander Dahl <ada@...rsis.com>, linux-mtd@...ts.infradead.org,
	Richard Weinberger <richard@....at>,
	Vignesh Raghavendra <vigneshr@...com>,
	Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Claudiu Beznea <claudiu.beznea@...on.dev>,
	Kees Cook <kees@...nel.org>,
	"Gustavo A. R. Silva" <gustavoars@...nel.org>,
	"moderated list:ARM/Microchip (AT91) SoC support" <linux-arm-kernel@...ts.infradead.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: nand: raw: atmel: Add message on DMA usage

Hi Miquel,

Am Wed, Aug 21, 2024 at 03:17:01PM +0200 schrieb Miquel Raynal:
> Hi Alexander,
> 
> ada@...rsis.com wrote on Wed, 21 Aug 2024 14:05:16 +0200:
> 
> > Like for other atmel drivers (serial, crypto, mmc, …), too.
> > 
> > Signed-off-by: Alexander Dahl <ada@...rsis.com>
> > ---
> >  drivers/mtd/nand/raw/atmel/nand-controller.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
> > index dc75d50d52e8..9e6dea2cf140 100644
> > --- a/drivers/mtd/nand/raw/atmel/nand-controller.c
> > +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
> > @@ -2051,6 +2051,8 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc,
> >  		nc->dmac = dma_request_channel(mask, NULL, NULL);
> >  		if (!nc->dmac)
> >  			dev_err(nc->dev, "Failed to request DMA channel\n");
> > +		dev_info(nc->dev, "using %s for DMA transfers\n",
> > +			 dma_chan_name(nc->dmac));
> 
> 
> The message here would be misleading if !nc->dmac.

Of course you're right, this is somewhat embarassing.  I'll send a v2.

Thanks for reviewing.
Alex

> 
> >  	}
> >  
> >  	/* We do not retrieve the SMC syscon when parsing old DTs. */
> > 
> > base-commit: 47ac09b91befbb6a235ab620c32af719f8208399
> 
> 
> Thanks,
> Miquèl