linux-kernel - Re: [PATCH v2] media: rockchip: rga: fix rga offset lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZsXzO_Db_OmV4aW2@pengutronix.de>
Date: Wed, 21 Aug 2024 16:01:31 +0200
From: Michael Tretter <m.tretter@...gutronix.de>
To: John Keeping <jkeeping@...usicbrands.com>
Cc: linux-media@...r.kernel.org, Jacob Chen <jacob-chen@...wrt.com>,
	Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Heiko Stuebner <heiko@...ech.de>,
	Hans Verkuil <hverkuil-cisco@...all.nl>,
	linux-rockchip@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	kernel@...gutronix.de
Subject: Re: [PATCH v2] media: rockchip: rga: fix rga offset lookup

On Sat, 10 Aug 2024 14:02:54 +0100, John Keeping wrote:
> The arguments to rga_lookup_draw_pos() are passed in the wrong order,
> rotate mode should be before mirror mode.

Thanks for the patch!

> 
> Fixes: 558c248f930e6 ("media: rockchip: rga: split src and dst buffer setup")
> Signed-off-by: John Keeping <jkeeping@...usicbrands.com>

Reviewed-by: Michael Tretter <m.tretter@...gutronix.de>

> ---
>  drivers/media/platform/rockchip/rga/rga-hw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/rockchip/rga/rga-hw.c b/drivers/media/platform/rockchip/rga/rga-hw.c
> index 11c3d72347572..b2ef3beec5258 100644
> --- a/drivers/media/platform/rockchip/rga/rga-hw.c
> +++ b/drivers/media/platform/rockchip/rga/rga-hw.c
> @@ -376,7 +376,7 @@ static void rga_cmd_set_dst_info(struct rga_ctx *ctx,
>  	 * Configure the dest framebuffer base address with pixel offset.
>  	 */
>  	offsets = rga_get_addr_offset(&ctx->out, offset, dst_x, dst_y, dst_w, dst_h);
> -	dst_offset = rga_lookup_draw_pos(&offsets, mir_mode, rot_mode);
> +	dst_offset = rga_lookup_draw_pos(&offsets, rot_mode, mir_mode);
>  
>  	dest[(RGA_DST_Y_RGB_BASE_ADDR - RGA_MODE_BASE_REG) >> 2] =
>  		dst_offset->y_off;
> -- 
> 2.46.0
> 
>