linux-kernel - Re: [PATCH] media: platform: rga: fix 32-bit DMA limitation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZsXzrV2vC4aB8GMq@pengutronix.de>
Date: Wed, 21 Aug 2024 16:03:25 +0200
From: Michael Tretter <m.tretter@...gutronix.de>
To: John Keeping <jkeeping@...usicbrands.com>
Cc: linux-media@...r.kernel.org, Jacob Chen <jacob-chen@...wrt.com>,
	Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Heiko Stuebner <heiko@...ech.de>,
	Hans Verkuil <hverkuil-cisco@...all.nl>,
	linux-rockchip@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	kernel@...gutronix.de
Subject: Re: [PATCH] media: platform: rga: fix 32-bit DMA limitation

On Mon, 12 Aug 2024 15:35:55 +0100, John Keeping wrote:
> The destination buffer flags are assigned twice but source is not set in
> what looks like a copy+paste mistake.  Assign the source queue flags so
> the 32-bit DMA limitation is handled consistently.
> 
> Fixes: ec9ef8dda2a24 ("media: rockchip: rga: set dma mask to 32 bits")
> Signed-off-by: John Keeping <jkeeping@...usicbrands.com>

Reviewed-by: Michael Tretter <m.tretter@...gutronix.de>

> ---
>  drivers/media/platform/rockchip/rga/rga.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c
> index 0e768f3e9edab..de532b7ecd74c 100644
> --- a/drivers/media/platform/rockchip/rga/rga.c
> +++ b/drivers/media/platform/rockchip/rga/rga.c
> @@ -102,7 +102,7 @@ queue_init(void *priv, struct vb2_queue *src_vq, struct vb2_queue *dst_vq)
>  	src_vq->drv_priv = ctx;
>  	src_vq->ops = &rga_qops;
>  	src_vq->mem_ops = &vb2_dma_sg_memops;
> -	dst_vq->gfp_flags = __GFP_DMA32;
> +	src_vq->gfp_flags = __GFP_DMA32;
>  	src_vq->buf_struct_size = sizeof(struct rga_vb_buffer);
>  	src_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY;
>  	src_vq->lock = &ctx->rga->mutex;
> -- 
> 2.46.0
> 
>