linux-kernel - Re: [PATCH 00/31] wifi: mwifiex: cleanup driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bk1mvujx.fsf@kernel.org>
Date: Wed, 21 Aug 2024 17:07:14 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Sascha Hauer <s.hauer@...gutronix.de>
Cc: Brian Norris <briannorris@...omium.org>,  Francesco Dolcini
 <francesco@...cini.it>,  linux-wireless@...r.kernel.org,
  linux-kernel@...r.kernel.org,  kernel@...gutronix.de
Subject: Re: [PATCH 00/31] wifi: mwifiex: cleanup driver

Sascha Hauer <s.hauer@...gutronix.de> writes:

> On Tue, Aug 20, 2024 at 08:42:38PM +0300, Kalle Valo wrote:
>> Sascha Hauer <s.hauer@...gutronix.de> writes:
>> 
>> > This series has a bunch of cleanup and bugfix patches for the mwifiex
>> > driver.
>> >
>> 
>> [...]
>> 
>> > ---
>> > Sascha Hauer (31):
>> 
>> BTW 30 patches is a lot to review. A good rule of thumb is to have max
>> 12 patches per patchset, maybe a bit more if the patches are small.
>> Splitting this into two patchsets would make it a lot more pleasent for
>> the reviewers.
>
> Ok, I'll split up this series into smaller chunks. Be prepared there are
> more to come

Awesome, keep them coming! 

> this driver is really full of cruft...

Honestly I have not not looked at the driver in detail but that's what
everyone are saying. So I appreciate you doing this. And I wish NXP
would help you in the effort, this a great way to learn how things work
in upstream.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches