linux-kernel - Re: [PATCH] mmc: core: Remove struct mmc_context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d5904b-2211-4c12-8057-bc251ca34e89@mleia.com>
Date: Wed, 21 Aug 2024 17:05:23 +0300
From: Vladimir Zapolskiy <vz@...ia.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 Ulf Hansson <ulf.hansson@...aro.org>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 linux-mmc@...r.kernel.org
Subject: Re: [PATCH] mmc: core: Remove struct mmc_context_info

On 8/21/24 16:24, Christophe JAILLET wrote:
> The 'mmc_context_info' structure is unused.
> 
> It has been introduced in:
> 
>    - commit 2220eedfd7ae ("mmc: fix async request mechanism for sequential
>      read scenarios")
> 
> in 2013-02 and its usages have been removed in:
> 
>    - commit 126b62700386 ("mmc: core: Remove code no longer needed after the
>      switch to blk-mq")
>    - commit 0fbfd1251830 ("mmc: block: Remove code no longer needed after
>      the switch to blk-mq")
> 
> in 2017-12.
> 
> Now remove this unused structure.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested in drivers/mmc/ only
> ---
>   include/linux/mmc/host.h | 14 --------------
>   1 file changed, 14 deletions(-)
> 
> diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
> index 49470188fca7..545bddfd7e1f 100644
> --- a/include/linux/mmc/host.h
> +++ b/include/linux/mmc/host.h
> @@ -292,20 +292,6 @@ struct mmc_slot {
>   	void *handler_priv;
>   };
>   
> -/**
> - * mmc_context_info - synchronization details for mmc context
> - * @is_done_rcv		wake up reason was done request
> - * @is_new_req		wake up reason was new request
> - * @is_waiting_last_req	mmc context waiting for single running request
> - * @wait		wait queue
> - */
> -struct mmc_context_info {
> -	bool			is_done_rcv;
> -	bool			is_new_req;
> -	bool			is_waiting_last_req;
> -	wait_queue_head_t	wait;
> -};
> -
>   struct regulator;
>   struct mmc_pwrseq;
>   

Reviewed-by: Vladimir Zapolskiy <vz@...ia.com>

--
Best wishes,
Vladimir