lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAOMZO5BJQ4RVRqvpcdAdXqhcfP6b7NbN-0VQZB7sBfYGKr8phw@mail.gmail.com>
Date: Wed, 21 Aug 2024 11:24:03 -0300
From: Fabio Estevam <festevam@...il.com>
To: Tarang Raval <tarang.raval@...iconsignals.io>
Cc: krzk+dt@...nel.org, shawnguo@...nel.org, Rob Herring <robh@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, devicetree@...r.kernel.org, imx@...ts.linux.dev, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] arm64: dts: imx8mm-emtop-baseboard: Add Peripherals Support

Hi Tarang,

On Wed, Aug 21, 2024 at 10:58 AM Tarang Raval
<tarang.raval@...iconsignals.io> wrote:

> +       can-control {
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&pinctrl_cancontrol>;
> +               reset-gpios = <&gpio1 15 GPIO_ACTIVE_HIGH>;
> +       };

This does not have any compatible string, so this can-control block
should be removed.

> +        can: can@0 {
> +                compatible = "microchip,mcp2515";
> +                pinctrl-names = "default";
> +                pinctrl-0 = <&pinctrl_canbus>;
> +                reg = <0>;

reg should come right after compatible.

> +       rtc@32 {
> +               compatible = "rx8025";

This gives a warning as rx8025 does not exist.

It should be "epson,rx8025" instead.

> +/* Wifi */
> +&usdhc1 {
> +       pinctrl-names = "default", "state_100mhz", "state_200mhz";
> +       pinctrl-0 = <&pinctrl_usdhc1>, <&pinctrl_usdhc1_gpio>;
> +       pinctrl-1 = <&pinctrl_usdhc1_100mhz>, <&pinctrl_usdhc1_gpio>;
> +       pinctrl-2 = <&pinctrl_usdhc1_200mhz>, <&pinctrl_usdhc1_gpio>;

pinctrl_usdhc1_gpio is not being used as you only pass pinctrl-names =
"default". Remove pinctrl_usdhc1_gpio.

> +/* SD-card */
> +&usdhc2 {
> +        pinctrl-names = "default";
> +        pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
> +        pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_gpio>;
> +        pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_gpio>;

pinctrl_usdhc2_gpio is not being used as you only pass pinctrl-names =
"default". Remove pinctrl_usdhc2_gpio.

> +        cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
> +        bus-width = <4>;
> +        status = "okay";
> +};
> +
>  &iomuxc {
> +
> +       pinctrl_canbus: canbusgrp {
> +               fsl,pins = <
> +                       MX8MM_IOMUXC_GPIO1_IO14_GPIO1_IO14              0x14
> +               >;
> +       };

Please add blank lines to separate the pinctrl groups.

> +       pinctrl_cancontrol: cancontrolgrp {

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ