linux-kernel - Re: [PATCH] firewire: core: update fw_device outside of device_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240821142546.GA48808@workstation.local>
Date: Wed, 21 Aug 2024 23:25:46 +0900
From: Takashi Sakamoto <o-takashi@...amocchi.jp>
To: linux1394-devel@...ts.sourceforge.net
Cc: Zijun Hu <zijun_hu@...oud.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firewire: core: update fw_device outside of
 device_find_child()

On Tue, Aug 20, 2024 at 10:21:32PM +0900, Takashi Sakamoto wrote:
> When detecting updates of bus topology, the data of fw_device is newly
> allocated and caches the content of configuration ROM from the
> corresponding node. Then, the tree of device is sought to find the
> previous data of fw_device corresponding to the node. If found, the
> previous data is updated and reused and the data of fw_device newly
> allocated is going to be released.
> 
> The above procedure is done in the call of device_find_child(), however it
> is a bit abusing against the intention of the helper function, since it is
> preferable to find only without updating.
> 
> This commit splits the update outside of the call.
> 
> Cc: Zijun Hu <zijun_hu@...oud.com>
> Signed-off-by: Takashi Sakamoto <o-takashi@...amocchi.jp>
> ---
>  drivers/firewire/core-device.c | 116 +++++++++++++++++----------------
>  1 file changed, 59 insertions(+), 57 deletions(-)

Applied to for-next branch.

Regards

Takashi Sakamoto