linux-kernel - Re: [PATCH 1/3] arm64: dts: freescale: imx93-11x11-evk: enable fsl, ext-reset-output for wdog3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZsX6iCUToi+VRCkK@lizhi-Precision-Tower-5810>
Date: Wed, 21 Aug 2024 10:32:40 -0400
From: Frank Li <Frank.li@....com>
To: Alexander Stein <alexander.stein@...tq-group.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	imx@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Peng Fan <peng.fan@....com>,
	"Peng Fan (OSS)" <peng.fan@....nxp.com>
Subject: Re: [PATCH 1/3] arm64: dts: freescale: imx93-11x11-evk: enable fsl,
 ext-reset-output for wdog3

On Wed, Aug 21, 2024 at 08:32:06AM +0200, Alexander Stein wrote:
> Hi,
>
> Am Dienstag, 20. August 2024, 17:02:39 CEST schrieb Peng Fan (OSS):
> > From: Peng Fan <peng.fan@....com>
> >
> > The WDOG_B is connected to external PMIC, so set "fsl,ext-reset-output"
> > to enable triggering PMIC reset.
> >
> > Signed-off-by: Peng Fan <peng.fan@....com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > index 60eb64761392..fb93ae654a2b 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > @@ -485,6 +485,7 @@ &usdhc2 {
> >  };
> >
> >  &wdog3 {
> > +	fsl,ext-reset-output;
>
> The MX93_PAD_WDOG_ANY__WDOG1_WDOG_ANY pinctrl is missing, no?
> Same for the other boards.

I think it should be already set in uboot. Otherwise if system halt before
kernel pin-mux driver probe, Wdog will not reset board.

Anyways, add pinctrl have not harmful here.

Frank

>
> Best regards,
> Alexander
>
> >  	status = "okay";
> >  };
> >
> >
> >
>
>
> --
> TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> http://www.tq-group.com/
>
>