linux-kernel - Re: [PATCH v2] drivers:block:Use IS_ERR() to check debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b6d12fa0-5642-441f-8289-a794435b2f17@vivo.com>
Date: Thu, 22 Aug 2024 20:50:42 +0800
From: Yang Ruibin <11162571@...o.com>
To: linux-block@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
 Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>,
 Dwaipayan Ray <dwaipayanray1@...il.com>,
 Lukas Bulwahn <lukas.bulwahn@...il.com>, Borislav Petkov <bp@...e.de>,
 Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org
Cc: opensource.kernel@...o.com
Subject: Re: [PATCH v2] drivers:block:Use IS_ERR() to check
 debugfs_create_dir() return value

Sorry, please ignore this patch for now. The wrong Fixes were used. This 
patch will be updated later.

在 2024/8/22 20:41, Yang Ruibin 写道:
> The debugfs_create_dir() function returns error pointers.It
> never returns NULL. So use IS_ERR() to check its return value.
>
> Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector")
> Signed-off-by: Yang Ruibin <11162571@...o.com>
> ---
>   drivers/block/pktcdvd.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
> index 7cece5884b9c..030b7a063a0b 100644
> --- a/drivers/block/pktcdvd.c
> +++ b/drivers/block/pktcdvd.c
> @@ -498,7 +498,7 @@ static void pkt_debugfs_dev_new(struct pktcdvd_device *pd)
>   	if (!pkt_debugfs_root)
>   		return;
>   	pd->dfs_d_root = debugfs_create_dir(pd->disk->disk_name, pkt_debugfs_root);
> -	if (!pd->dfs_d_root)
> +	if (IS_ERR(pd->dfs_d_root))
>   		return;
>   
>   	pd->dfs_f_info = debugfs_create_file("info", 0444, pd->dfs_d_root,