linux-kernel - RE: [Intel-wired-lan] [PATCH iwl-net v3] igb: Fix not clearing TimeSync interrupts for 82580

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CYYPR11MB842936EC47BD7C75EC331F48BD8F2@CYYPR11MB8429.namprd11.prod.outlook.com>
Date: Thu, 22 Aug 2024 13:05:12 +0000
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To: Daiwei Li <daiweili@...gle.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
CC: "Neftin, Sasha" <sasha.neftin@...el.com>, "Gomes, Vinicius"
	<vinicius.gomes@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "richardcochran@...il.com"
	<richardcochran@...il.com>, "kurt@...utronix.de" <kurt@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "davem@...emloft.net"
	<davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net v3] igb: Fix not clearing
 TimeSync interrupts for 82580

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Daiwei Li
> Sent: Wednesday, August 14, 2024 10:26 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: Daiwei Li <daiweili@...gle.com>; Neftin, Sasha <sasha.neftin@...el.com>; Gomes, Vinicius <vinicius.gomes@...el.com>; netdev@...r.kernel.org; richardcochran@...il.com; kurt@...utronix.de; linux-kernel@...r.kernel.org; edumazet@...gle.com; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; kuba@...nel.org; pabeni@...hat.com; davem@...emloft.net
> Subject: [Intel-wired-lan] [PATCH iwl-net v3] igb: Fix not clearing TimeSync interrupts for 82580
>
> 82580 NICs have a hardware bug that makes it necessary to write into the TSICR (TimeSync Interrupt Cause) register to clear it:
> https://lore.kernel.org/all/CDCB8BE0.1EC2C%25matthew.vick@intel.com/
>
> Add a conditional so only for 82580 we write into the TSICR register, so we don't risk losing events for other models.
>
> Without this change, when running ptp4l with an Intel 82580 card, I get the following output:
>
> > timed out while polling for tx timestamp increasing 
> > tx_timestamp_timeout or increasing kworker priority may correct this 
> > issue, but a driver bug likely causes it
>
> This goes away with this change.
>
> This (partially) reverts commit ee14cc9ea19b ("igb: Fix missing time sync events").
>
> Fixes: ee14cc9ea19b ("igb: Fix missing time sync events")
> Closes: https://lore.kernel.org/intel-wired-lan/CAN0jFd1kO0MMtOh8N2Ztxn6f7vvDKp2h507sMryobkBKe=xk=w@mail.gmail.com/
> Tested-by: Daiwei Li <daiweili@...gle.com>
> Suggested-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>
> Signed-off-by: Daiwei Li <daiweili@...gle.com>
> ---
>  drivers/net/ethernet/intel/igb/igb_main.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)