linux-kernel - Re: [PATCH v4 1/1] dt-bindings: extcon: ptn5150: add child node port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7620f6b3-347e-418d-b90b-487afa2ec32d@kernel.org>
Date: Thu, 22 Aug 2024 23:34:58 +0900
From: Chanwoo Choi <chanwoo@...nel.org>
To: Frank Li <Frank.Li@....com>, Krzysztof Kozlowski <krzk@...nel.org>,
 MyungJoo Ham <myungjoo.ham@...sung.com>, Chanwoo Choi
 <cw00.choi@...sung.com>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 "open list:NXP PTN5150A CC LOGIC AND EXTCON DRIVER"
 <linux-kernel@...r.kernel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>
Cc: imx@...ts.linux.dev
Subject: Re: [PATCH v4 1/1] dt-bindings: extcon: ptn5150: add child node port

24. 8. 20. 23:39에 Frank Li 이(가) 쓴 글:
> Add child node 'port' to allow connect to usb controller to do role-switch
> if id pin of ptn5150 have not connected to chip's usb ID function pin.
> 
> Fix below warning:
> arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dtb: typec@3d: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
>         from schema $id: http://devicetree.org/schemas/extcon/extcon-ptn5150.yaml
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
> Change from v3 to v4
> - remove extra empty line
> - fix Indentation in example
> Change from v2 to v3
> - only add port to existed example.
> Change from v1 to v2
> - add example for id pin have not connect to main chip's id example.
> - commit 095b96b2b fix "port" warning, but add new warning "connector" is
> not exist. And follow commit revert this change.
> 690085d866f08 Revert "arm64: dts: imx8mn-var-som-symphony: Describe the USB-C connector
> - I have not board in hand to debug why "connector" is not work.
> ---
>  .../devicetree/bindings/extcon/extcon-ptn5150.yaml    | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml b/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
> index d5cfa32ea52dd..072b3c0c5fd03 100644
> --- a/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
> +++ b/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
> @@ -37,6 +37,11 @@ properties:
>        GPIO pin (output) used to control VBUS. If skipped, no such control
>        takes place.
>  
> +  port:
> +    $ref: /schemas/graph.yaml#/properties/port
> +    description:
> +      A port node to link the usb controller for the dual role switch.
> +
>  required:
>    - compatible
>    - interrupts
> @@ -58,5 +63,11 @@ examples:
>              interrupt-parent = <&msmgpio>;
>              interrupts = <78 IRQ_TYPE_LEVEL_HIGH>;
>              vbus-gpios = <&msmgpio 148 GPIO_ACTIVE_HIGH>;
> +
> +            port {
> +                endpoint {
> +                    remote-endpoint = <&usb1_drd_sw>;
> +                };
> +            };
>          };
>      };

Applied it. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi