linux-kernel - Re: [PATCH v3] HID: corsair-void: Add Corsair Void headset family driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALTg27=xcMSyq0vyxRJWyeqABa-MBfvDxC3cKHaTPnA2X1meqg@mail.gmail.com>
Date: Thu, 22 Aug 2024 16:14:23 +0100
From: Stuart <stuart.a.hayhurst@...il.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: linux-input@...r.kernel.org, Jiri Kosina <jikos@...nel.org>, 
	Benjamin Tissoires <bentiss@...nel.org>, linux-kernel@...r.kernel.org, 
	Markus Elfring <Markus.Elfring@....de>
Subject: Re: [PATCH v3] HID: corsair-void: Add Corsair Void headset family driver

> BTW, the return value of corsair_void_request_status() is not used.
> Does it make sense to change it into avoid function?

Good catch, I've moved the error reporting to its callers instead,
that means we can ditch the default case then and simplify it

Stuart