[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240822154059.1066595-5-sean.anderson@linux.dev>
Date: Thu, 22 Aug 2024 11:40:58 -0400
From: Sean Anderson <sean.anderson@...ux.dev>
To: Radhey Shyam Pandey <radhey.shyam.pandey@....com>,
netdev@...r.kernel.org
Cc: linux-arm-kernel@...ts.infradead.org,
Eric Dumazet <edumazet@...gle.com>,
Michal Simek <michal.simek@....com>,
Andrew Lunn <andrew@...n.ch>,
Daniel Borkmann <daniel@...earbox.net>,
"David S . Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
linux-kernel@...r.kernel.org,
Paolo Abeni <pabeni@...hat.com>,
Sean Anderson <sean.anderson@...ux.dev>,
Simon Horman <horms@...nel.org>
Subject: [PATCH net-next v3 4/5] net: xilinx: axienet: Don't set IFF_PROMISC in ndev->flags
Contrary to the comment, we don't have to inform the net subsystem.
Signed-off-by: Sean Anderson <sean.anderson@...ux.dev>
Reviewed-by: Simon Horman <horms@...nel.org>
---
(no changes since v2)
Changes in v2:
- Split off from printing changes
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index f612adb07a25..5c4a5949a021 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -439,11 +439,6 @@ static void axienet_set_multicast_list(struct net_device *ndev)
if (ndev->flags & (IFF_ALLMULTI | IFF_PROMISC) ||
netdev_mc_count(ndev) > XAE_MULTICAST_CAM_TABLE_NUM) {
- /* We must make the kernel realize we had to move into
- * promiscuous mode. If it was a promiscuous mode request
- * the flag is already set. If not we set it.
- */
- ndev->flags |= IFF_PROMISC;
reg = axienet_ior(lp, XAE_FMI_OFFSET);
reg |= XAE_FMI_PM_MASK;
axienet_iow(lp, XAE_FMI_OFFSET, reg);
--
2.35.1.1320.gc452695387.dirty
Powered by blists - more mailing lists