linux-kernel - Re: [PATCH v2] mtd: nand: raw: atmel: Add message on DMA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a65c4728-4cec-4fb0-a00f-052b0e08d7c1@microchip.com>
Date: Thu, 22 Aug 2024 17:54:53 +0200
From: Nicolas Ferre <nicolas.ferre@...rochip.com>
To: Alexander Dahl <ada@...rsis.com>, <linux-mtd@...ts.infradead.org>
CC: Miquel Raynal <miquel.raynal@...tlin.com>, Richard Weinberger
	<richard@....at>, Vignesh Raghavendra <vigneshr@...com>, Alexandre Belloni
	<alexandre.belloni@...tlin.com>, Claudiu Beznea <claudiu.beznea@...on.dev>,
	Kees Cook <kees@...nel.org>, Tudor Ambarus <tudor.ambarus@...aro.org>,
	"moderated list:ARM/Microchip (AT91) SoC support"
	<linux-arm-kernel@...ts.infradead.org>, open list
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] mtd: nand: raw: atmel: Add message on DMA usage

On 21/08/2024 at 16:20, Alexander Dahl wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Like for other atmel drivers (serial, crypto, mmc, …), too.
> 
> Signed-off-by: Alexander Dahl <ada@...rsis.com>

Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

> ---
> 
> Notes:
>      v1 -> v2:
>      - make info message conditional (thanks Miquel)
> 
>   drivers/mtd/nand/raw/atmel/nand-controller.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
> index dc75d50d52e8..f9ccfd02e804 100644
> --- a/drivers/mtd/nand/raw/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
> @@ -2049,7 +2049,10 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc,
>                  dma_cap_set(DMA_MEMCPY, mask);
> 
>                  nc->dmac = dma_request_channel(mask, NULL, NULL);
> -               if (!nc->dmac)
> +               if (nc->dmac)
> +                       dev_info(nc->dev, "using %s for DMA transfers\n",
> +                                dma_chan_name(nc->dmac));
> +               else
>                          dev_err(nc->dev, "Failed to request DMA channel\n");
>          }
> 
> 
> base-commit: 47ac09b91befbb6a235ab620c32af719f8208399
> --
> 2.39.2
>